src/server-extension/types.ts (2)

42-49: Consider renaming attestorId to be more descriptive.

While the implementation is correct, consider renaming attestorId to something more descriptive like userId or voucherId to better reflect its purpose in the context of vouch counting.

---

51-58: LGTM! Consider adding JSDoc comments.

The implementation is well-structured and follows the existing patterns. To improve maintainability, consider adding JSDoc comments to describe the purpose of this result type and its fields.

Example documentation:

+/**
+ * Represents the result of counting vouches grouped by user
+ */
 @ObjectType()
 export class VouchCountByUserResult {
+  /** Total number of vouches across all users */
   @Field(() => Int)
   totalVouches: number = 0;

+  /** Breakdown of vouch counts per user */
   @Field(() => [VouchCountByUser])
   vouchCountByUser: VouchCountByUser[] = [];
 }

src/server-extension/organization-resolver.ts (3)

116-135: Consider performance optimizations for the SQL query

A few suggestions to optimize the query:

1. Consider using LEFT JOIN instead of INNER JOIN if you need to include attestors with no vouches
2. Add pagination to handle large result sets
3. Consider adding appropriate indexes for the WHERE clause conditions

-        SELECT 
-          attestor_organisation.attestor_id AS attestor_id,
-          COUNT(*) AS total_count
-        FROM 
-          project_attestation
-        JOIN attestor_organisation 
-          ON project_attestation.attestor_organisation_id = attestor_organisation.id
-        JOIN project
-          ON project_attestation.project_id = project.id
-        WHERE 
-          attestor_organisation.organisation_id = $1
-          AND project.source = $2
-          AND project_attestation.vouch = true
-          AND project_attestation.attest_timestamp BETWEEN $3 AND $4
-        GROUP BY 
-          attestor_organisation.attestor_id
-        ORDER BY 
-          total_count DESC;
+        SELECT 
+          attestor_organisation.attestor_id AS attestor_id,
+          COUNT(*) AS total_count
+        FROM 
+          project_attestation
+        LEFT JOIN attestor_organisation 
+          ON project_attestation.attestor_organisation_id = attestor_organisation.id
+        LEFT JOIN project
+          ON project_attestation.project_id = project.id
+        WHERE 
+          attestor_organisation.organisation_id = $1
+          AND project.source = $2
+          AND project_attestation.vouch = true
+          AND project_attestation.attest_timestamp BETWEEN $3 AND $4
+        GROUP BY 
+          attestor_organisation.attestor_id
+        ORDER BY 
+          total_count DESC
+        LIMIT $5
+        OFFSET $6;

---

156-161: Enhance error handling with specific error types

The current error handling catches all errors and wraps them in a generic Error. Consider:

1. Creating specific error types for different failure scenarios
2. Adding more context in error messages (e.g., including the organisationId)

-    } catch (error: any) {
-      console.error("Error fetching attestor vouch count by source:", error);
-      throw new Error(
-        `Failed to fetch attestor vouch count by source: ${error.message}`
-      );
+    } catch (error: any) {
+      console.error(
+        `Error fetching attestor vouch count by source for organisation ${organisationId}:`,
+        error
+      );
+      if (error.code === '23503') {  // Foreign key violation
+        throw new Error(`Organisation ${organisationId} not found`);
+      }
+      throw new Error(
+        `Failed to fetch attestor vouch count by source for organisation ${organisationId}: ${error.message}`
+      );

---

93-162: Consider adding unit tests for the new functionality

The new query method should be thoroughly tested, including:

• Happy path with various date ranges
• Edge cases for date validation
• Error scenarios
• Empty result handling

Would you like me to help generate comprehensive unit tests for this new functionality?

Configuration used: CodeRabbit UI
Review profile: CHILL

#!/bin/bash
# Description: Check naming conventions for similar types and fields

# Check for other uses of "attestor" vs "user" terminology
rg -i "attestor|vouch.*user" --type ts

# Check for similar result type patterns
ast-grep --pattern '@ObjectType()
export class $_Result {
  $$$
}'